Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check for version of nested messages during handling messages from database #1051

Closed
kbeker opened this issue Jan 7, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@kbeker
Copy link
Contributor

kbeker commented Jan 7, 2019

Quote from #857 blueprint:

receive/ endpoint
Since Concent creates responses on the fly, the client will always get a response containing a message created with Concent's version of golem-messages. Client can see this version in the Concent-Golem-Messages-Version HTTP header on the response.

If the response needs to contain a nested message taken from the database and that message is not compatible with Concent's version of golem-messages, Concent responds with ServiceRefused. The client is always required to stay on the same protocol version while communicating about the same subtask.

@kbeker kbeker added bug not in pivotal Not yet added as a task in any story in Pivotal labels Jan 7, 2019
@PaweuB
Copy link

PaweuB commented Jan 7, 2019

@PaweuB PaweuB removed the not in pivotal Not yet added as a task in any story in Pivotal label Jan 7, 2019
@cameel
Copy link
Contributor

cameel commented Jan 7, 2019

Update: we'll respond with HTTP 404 if versions are not compatible.

@pawelkisielewicz
Copy link
Contributor

pawelkisielewicz commented Jan 10, 2019

There was no missing protocol version's validation of nested messages during handling messages from database. It was and still is validated if concent's protocol version is compatible with protocol version in task_to_compute of pending response. It is enough, because in clean method of Subtask is validated, that all stored messages connected with one Subtask have the same protocol version.

It is only need to change concent's response from ServiceRefused to Http404, it is done in referenced pull request

@kbeker kbeker added this to the next milestone Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants