Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify eth address and requestor singularity in ForcePayment #545

Closed
jiivan opened this issue Jun 22, 2018 · 2 comments
Closed

Verify eth address and requestor singularity in ForcePayment #545

jiivan opened this issue Jun 22, 2018 · 2 comments
Assignees
@pawelkisielewicz
Labels
bug from-client payment use case 'force payment' use case
Milestone
0.8.0

Comments

@jiivan
Copy link

jiivan commented Jun 22, 2018

In golem_messages.message.concents.ForcePayment.subtask_results_accepted_list all SRA messages should be connected to one eth account and requested by one Requestor. Concent should respond with ServiceRefused otherwise.
@kbeker kbeker added not in pivotal Not yet added as a task in any story in Pivotal bug labels Jun 22, 2018
@cameel cameel added the payment use case 'force payment' use case label Jun 22, 2018
@cameel
Copy link
Contributor

cameel commented Jun 22, 2018

Right. Each account needs to be processed separately. This is a high priority bug.

BTW: @adrianzamorski @lukasz-glen I wanted to mention Paweł Bochanysz so that he can add it to Pivotal but looks like he still has not been added to Github.

@PaweuB PaweuB removed the not in pivotal Not yet added as a task in any story in Pivotal label Jun 22, 2018
@pawelkisielewicz pawelkisielewicz self-assigned this Jun 25, 2018
@pawelkisielewicz
Copy link
Contributor

If it is possible please add a REASON for it in golem_messages.message.concents.ServiceRefused. Concent should answer with ServiceRefused, but there is no matching REASON for this case.

@pawelkisielewicz pawelkisielewicz mentioned this issue Jun 26, 2018
Merged
@cameel cameel added this to the 0.8.0 milestone Jul 31, 2018
This was referenced Dec 7, 2018
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelkisielewicz pawelkisielewicz

Labels
bug from-client payment use case 'force payment' use case
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
5 participants
@cameel @jiivan @kbeker @pawelkisielewicz @PaweuB