Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'athens-proxy' build step in drone should build an Athens image and run it, instead of using the canary image #1481

Open
arschles opened this issue Dec 5, 2019 · 1 comment

Comments

@arschles
Copy link
Member

arschles commented Dec 5, 2019

Describe the bug

Since we're using the canary image, we are running the Athens server was built from the previous merge to master. That might be useful, but I think it's more useful to run the current one and test against that.

Error Message

N/A

To Reproduce

N/A

Expected behavior

N/A

Environment (please complete the following information):

N/A

Additional context

N/A

@arschles
Copy link
Member Author

arschles commented Dec 5, 2019

This might be tough to do in drone, since we need to run Athens as a service. Not sure if we could do it in GH actions (#1460) either...

We could possibly build and run an Athens container (we currently only run it as a process in the background) as part of e2e tests (#1474)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant