Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs with a '-' do not work for cookieRewrites #55

Open
kristiehoward opened this issue Jul 8, 2016 · 0 comments
Open

URLs with a '-' do not work for cookieRewrites #55

kristiehoward opened this issue Jul 8, 2016 · 0 comments

Comments

@kristiehoward
Copy link

We are trying to use your cookieRewrite functionality in order to pass cookies back through our proxy from our staging server to localhost. Our staging URL looks like name-stage.otherName.com, which does not match the regex /(Domain)=[a-z\.-_]*?(;|$)/gi in https://github.com/andrewrk/node-proxy-middleware/blob/master/index.js#L110. This blocks the cookieRewrite from actually happening.

Is there a reason you have excluded URLs with a - in them? If not, please update the regex to match URLs such as myurl-stage.com. I can put out a PR if you want :) we used /(Domain)=[a-z\.-_-]*?(;|$)/gi locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant