Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of LMF IDs when adding lexicons #101

Open
goodmami opened this issue Feb 17, 2021 · 1 comment
Open

Validation of LMF IDs when adding lexicons #101

goodmami opened this issue Feb 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@goodmami
Copy link
Owner

SQL errors can be hard to understand, especially for a user of Wn. To avoid these, some validation of the LMF files should be performed, such as ensuring that all IDs referenced are provided by the document (including as external elements in extension lexicons).

There is already some validation, e.g., of allowed part of speech values, relation types, etc, but so far nothing regarding entity linking. Things like cycle detection are probably too expensive to do during add, though.

@goodmami goodmami added the enhancement New feature or request label Feb 17, 2021
@goodmami goodmami changed the title Validation of LMF IDs Validation of LMF IDs when adding lexicons Feb 18, 2021
@goodmami goodmami added this to the v0.9.0 milestone Oct 19, 2021
@goodmami goodmami mentioned this issue Nov 15, 2021
@goodmami goodmami removed this from the v0.9.0 milestone Nov 18, 2021
@goodmami
Copy link
Owner Author

Validation is now handled with wn.validate, so I'm pulling this off the v0.9.0 milestone to avoid holding it up. I think we need to to re-evaluate what to do here. One option: catch SQL errors on adding a lexicon and suggest to the user to validate it first. For this to be effective, I think we need an easy way to load an LMF lexicon from a file stored in the cache so it could be passed to wn.validate.validate().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant