Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bots receive incorrect timesteps in Scenario #3

Closed
jagapiou opened this issue Sep 14, 2021 · 0 comments
Closed

Bots receive incorrect timesteps in Scenario #3

jagapiou opened this issue Sep 14, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jagapiou
Copy link
Member

Due to an errant - bots were sent timesteps (1, ..., num_bots + 1) rather than (num_bots, ...) as intended. This was fixed in 09b69a5.

This will completely mess up the behavior of the bots on the scenarios as they don't see their own observations, and so any evaluation run using before this fix will be incorrect and should be rerun.

(NOTE: this didn't affect our experiments run for the Melting Pot paper since these weren't run using Scenario.)

@jagapiou jagapiou self-assigned this Sep 14, 2021
@jagapiou jagapiou pinned this issue Sep 14, 2021
@jagapiou jagapiou added the bug Something isn't working label Sep 14, 2021
@jagapiou jagapiou unpinned this issue Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant