Following up on PR 1296, implement both APIs for search_sorted. #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: google-research#1296 (comment) The more basic API, still named `search_sorted`, returns a `Post n`. The idea is that the elements of `xs` are fence sections, and we find the position between them (inclusive on either end) where `x` falls in the ordering. In terms of this, we now define `search_sorted_exact` (better name?), which returns a `Maybe n`, which is the index of an element of `xs` that equals `x` exactly, or `Nothing` if such does not exist. Also reorder the prelude slightly to try to both maintain semantic groupings and respect name resolution dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1296 (comment)
The more basic API, still named
search_sorted, returns aPost n. The idea is that the elements ofxsare fence sections, and we find the position between them (inclusive on either end) wherexfalls in the ordering.In terms of this, we now define
search_sorted_exact(better name?), which returns aMaybe n, which is the index of an element ofxsthat equalsxexactly, orNothingif such does not exist.Also reorder the prelude slightly to try to both maintain semantic groupings and respect name resolution dependencies.