You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As pointed out in #165 (comment), we currently allow comments that exceed the maximum line length normally allowed by Rustfmt.
We could enable the wrap_comments option in rustfmt.toml to make sure the comments don't exceed this maximum length, and are wrapped properly. This however requires a few things.
As indicated, I expected this to automatically checked. No strong opinion however, where are ASCII art examples that would need refactoring?
It'd be easier to have an exhaustive list while reviewing code, but for a start src/ctap/ctap1.rs has some tables (not sure if it should be best described as "ASCII art" or "markdown").
Just wanted to know if you have an intuition about how much we have to change. But it seems like our code would be nicer with correct length comments? But I'd say it's low priority.
As pointed out in #165 (comment), we currently allow comments that exceed the maximum line length normally allowed by Rustfmt.
We could enable the
wrap_comments
option inrustfmt.toml
to make sure the comments don't exceed this maximum length, and are wrapped properly. This however requires a few things.wrap_comments
option is currently unstable ([unstable option] wrap_comments rust-lang/rustfmt#3347), so we have to decide if we want to commit to using it.The text was updated successfully, but these errors were encountered: