Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slider control #201

Closed
jingtang10 opened this issue Jan 31, 2021 · 6 comments · Fixed by #287
Closed

Add slider control #201

jingtang10 opened this issue Jan 31, 2021 · 6 comments · Fixed by #287
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed type:enhancement New feature or request

Comments

@jingtang10
Copy link
Collaborator

See http://hl7.org/fhir/R4/valueset-questionnaire-item-control.html for slider

@jingtang10 jingtang10 added type:enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 31, 2021
@AliAkberAakash
Copy link

Hi, I'd like to contribute to this issue. Where do I have to add the slider?

@jingtang10
Copy link
Collaborator Author

jingtang10 commented Feb 1, 2021

Hi Ali - thanks for your interest. Please refer to PR #191 where I added a radio button control. To add a new slider control you will do something very similar.

A few important things you'll need to do

  • create a new layout file for the slider widget
  • create a new factory class that will use the layout file to create the view holder
  • change the QuestionnaireItemAdapter.kt file so that it uses the new factory for numbers
  • add tests

please take a look at that PR and let me know if you have questions.

@jingtang10
Copy link
Collaborator Author

Ali - may I ask you to download the repo and try to build the datacapturegallery module first. Once you've done that and you're clear what to do I can grant write access.

@jingtang10
Copy link
Collaborator Author

An example can be found here: http://build.fhir.org/ig/HL7/sdc/examples.html#using-sliderstepvalue

@s-ayush2903
Copy link
Contributor

This has been solved in #287, Issue can be closed.

@jingtang10 jingtang10 linked a pull request Mar 16, 2021 that will close this issue
@jingtang10
Copy link
Collaborator Author

Thanks @s-ayush2903!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed type:enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants