Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make string search case-insensitive by default #400

Closed
jingtang10 opened this issue Mar 29, 2021 · 8 comments · Fixed by #421
Closed

Make string search case-insensitive by default #400

jingtang10 opened this issue Mar 29, 2021 · 8 comments · Fixed by #421
Assignees
Labels
good first issue Good for newcomers type:enhancement New feature or request

Comments

@jingtang10
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
String search is case-sensitive in the API by default.

Describe the solution you'd like
Make search case-insensitive by default. Probably should use COLLATE NOCASE in the SQL query.

This is releated to #376

Describe alternatives you've considered
NA

Additional context
https://www.hl7.org/fhir/search.html#string indicates search should be case-insensitive by default.

Would you like to work on the issue?
This would be a good starter issue.

@jingtang10 jingtang10 added type:enhancement New feature or request good first issue Good for newcomers labels Mar 29, 2021
@maanuanubhav999
Copy link
Contributor

@jingtang10 i would like to work on this.

@jingtang10
Copy link
Collaborator Author

yeah this is probably a small PR to send. please feel free to raise one. but please write down your plan here. also you should probably wait until #395 is merged.

@maanuanubhav999
Copy link
Contributor

okay. Currently figuring out the API working and will be using the statement-level collation as asked above.

@maanuanubhav999
Copy link
Contributor

@jingtang10 I need help here. We need to make every String search case-insensitive. Before that, we will need to complete #376 am I correct?

@Syed-Affan-Hameed
Copy link

Hi! @jingtang10 is this issue still open can I work on this 2/8 tasks are still incomplete.

@maanuanubhav999
Copy link
Contributor

hello, @Syed-Affan-Hameed issue is completed, all it needed was some check. thanks.

@Syed-Affan-Hameed
Copy link

@maanuanubhav999 Can you suggest me some open issues?

@epicadk
Copy link
Contributor

epicadk commented Apr 17, 2021

@jingtang10 the current solution will only work for ASCII text. Do we not plan on support other encodings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type:enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants
@maanuanubhav999 @jingtang10 @epicadk @Syed-Affan-Hameed and others