Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regressions found in Brotli v1.1.0 #1202

Open
carlossanlop opened this issue Sep 19, 2024 · 0 comments
Open

Performance regressions found in Brotli v1.1.0 #1202

carlossanlop opened this issue Sep 19, 2024 · 0 comments

Comments

@carlossanlop
Copy link

The dotnet/runtime repo recently updated its in-tree copy of its Brotli dependency from v1.0.9 to v1.1.0.

We ran our performance benchmarks, and we noticed regressions in Linux-x64 and Windows-x64.

Most of our regression results were under 15%, but 6 results were between 39% an 49%.

Here's a list of the tests that showed regressions:

Windows x64

  • 49% - Decompress_WithState(level: Fastest, file: "TestDocument.pdf")
  • 47% - Decompress_WithState(level: Optimal, file: "TestDocument.pdf")
  • 47% - Decompress_WithoutState(level: Fastest, file: "TestDocument.pdf")
  • 47% - Decompress_WithoutState(level: Optimal, file: "TestDocument.pdf")
  • 39% - Decompress(level: Fastest, file: "TestDocument.pdf")
  • 39% - Decompress(level: Optimal, file: "TestDocument.pdf")
  • 13% - Decompress_WithoutState(level: Fastest, file: "alice29.txt")
  • 12% - Decompress_WithoutState(level: Optimal, file: "alice29.txt")
  • 12% - Decompress_WithState(level: Fastest, file: "alice29.txt")
  • 11% - Decompress_WithState(level: Optimal, file: "alice29.txt")
  • 11% - Decompress(level: Fastest, file: "alice29.txt")
  • 10% - Decompress(level: Optimal: file: "alice29.txt")
  • 10% - Decompress_WithState(level: Fastest, file: "sum")
  • 10% - Decompress_WithoutState(level: Fastest, file: "sum")
  • 09% - Decompress(level: Fastest, file: "sum")

Linux x64

  • 16% - Compress_WithoutState(level: Optimal, file: "TestDocument.pdf")
  • 16% - Compress_WithState(level: Optimal, file: "TestDocument.pdf")
  • 15% - Compress_WithoutState(level: Optimal, file: "alice29.txt")
  • 15% - Compress_WithoutState(level: Optimal, file: "sum")
  • 14% - Compress_WithState(level: Optimal, file: "sum")
  • 13% - Compress_WithState(level: Optimal, file: "alice29.txt")

Some more info:

Unfortunately, the v1.1.0 tag has no mention of known perf regressions, so we were wondering if you were aware of these results and if you could help us figure out the possible root causes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant