-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterate through all revisions to find first good revision before bisecting. #3934
Draft
letitz
wants to merge
10
commits into
google:master
Choose a base branch
from
letitz:regbad2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alhijazi PTAL while I work out how to write some kind of integration test. |
alhijazi
approved these changes
Apr 12, 2024
Thanks! Onto @jonathanmetzman, who may have suggestions on how/where to write an overarching test. |
jonathanmetzman
force-pushed
the
master
branch
2 times, most recently
from
May 28, 2024 07:18
e7e91a0
to
22e1108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds on #3927 to change the way regression task operates.
To review, given GitHub's lack of support for stacked PRs, this link should work: https://github.com/google/clusterfuzz/pull/3934/files/1bdca4468269ee897b5145f6dc24c395b6eb4d2d..dc74698caba2f0ce6512eca69d93d41d1692aef7
The overall goal is to be more dogged when trying to find the first good revision to start bisecting from, and try all revisions. This may take too long, so we respect the task deadline and ensure that this step is resumable in a subsequent regression task. Regression task already supports resuming timed out regressions later, as this is how the core bisection works.
Previously, regression task would start its first run (detected by the absence of
last_regression_min
orlast_regression_max
metadata on the testcase) by:This change does a few things:
last_regression_max
andlast_regression_min
last_regression_max
is absent from the testcase:last_regression_max
on the testcase to indicate this happenedlast_regression_min
is absent from the testcase:last_regression_min
as we go along to record our progresscheck_latest_revisions
andfind_earliest_good_revision
check_latest_revisions
orfind_earliest_good_revision
TODO: An integration test of some kind that checks that forward progress is made after timeouts.