Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libraries conflict with dependencies bundled in dagger-compiler.jar #349

Closed
gfx opened this issue Apr 1, 2016 · 2 comments
Closed

libraries conflict with dependencies bundled in dagger-compiler.jar #349

gfx opened this issue Apr 1, 2016 · 2 comments

Comments

@gfx
Copy link

gfx commented Apr 1, 2016

dagger-compiler bundles lots of libraries, not as maven dependencies. This causes problems when another annotation processing library uses a newer version of libraries that are used in dagger-compiler.

For example, there is an annotation processor that uses JavaPoet 1.6 feature (e.g. CodeBlock.of()), does not work with Dagger 2.2 because JavaPoet 1.5.1, bundled in dagger-compiler, is loaded.

I think dagger-compiler should not bundle any libraries because users can't control their versions.

Environment

  • JDK 1.8.0_77
  • Dagger 2.2
@tbroyer
Copy link

tbroyer commented Apr 1, 2016

Partly a dupe of #228, but JavaPoet is new in Dagger 2.2, and the issue here is that maven-shade-plugin is lacking a relocation rule for com.squareup.

@gk5885
Copy link

gk5885 commented Apr 7, 2016

OK, then I think we can just close this as a dupe of #228 and update that to include javapoet as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants