Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlinx.metadata to 0.6.1 #3893

Closed
lwasyl opened this issue May 30, 2023 · 8 comments
Closed

Update kotlinx.metadata to 0.6.1 #3893

lwasyl opened this issue May 30, 2023 · 8 comments

Comments

@lwasyl
Copy link

lwasyl commented May 30, 2023

Release: https://github.com/JetBrains/kotlin/blob/master/libraries/kotlinx-metadata/jvm/ChangeLog.md#061

Right now testing K2 in projects using Dagger might be tricky (or impossible) if Dagger accesses classes from other modules that were built with K2, as it can't read classes metadata.

See https://youtrack.jetbrains.com/issue/KT-58898 for context, the issue talks about android projects but I think it's not Android specific at all

@Chang-Eric
Copy link
Member

Thanks for filing this. Just to let you know, this will probably take a bit longer than you might expect because there are some internal dependencies we need to coordinate with for this version bump.

@lwasyl
Copy link
Author

lwasyl commented May 30, 2023

Sure, I'll just point out that the 0.6.1 release was specifically published to help users test the K2 compiler and, if the release notes are correct, doesn't require any code migration. So hopefully the effort to bump it is relatively small 🙂

@Chang-Eric
Copy link
Member

Thanks for the note! The complications mostly have to do with our internal build systems and how our code gets pushed out/what versions are available to us to use. So that's what I meant by it will take longer than you might expect for a change like this.

@lwasyl
Copy link
Author

lwasyl commented Jun 1, 2023

Heads up, looks like 0.6.1 is having some issues and perhaps only 0.6.2 will help: https://youtrack.jetbrains.com/issue/KT-59040

@ZacSweers
Copy link

0.6.2 should be used 👍

@danysantiago
Copy link
Member

Sorry for the delay, the dependency was updated in 7b16dfd and the change will be available in the next release.

@sandwwraith
Copy link

Hi! Does Dagger shadow or bundle otherwise kotlinx-metadata-jvm dependency? Judging by #3951 and https://youtrack.jetbrains.com/issue/KT-58898, forcing kotlinx-metadata version in Gradle buildscript doesn't help. When this new Dagger release will be available?

@TWiStErRob
Copy link

@sandwwraith 2.47 is released, quoting this as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants