Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test which uses latest-built compiler #995

Closed
ronshapiro opened this issue Dec 19, 2017 · 2 comments
Closed

Add integration test which uses latest-built compiler #995

ronshapiro opened this issue Dec 19, 2017 · 2 comments

Comments

@ronshapiro
Copy link

ronshapiro commented Dec 19, 2017

#994 identified an issue where we forgot to shade the dagger-spi artifact. Our tests never found this since they don't use maven. We should have a test that runs util/install-local-snapshot.sh and then runs a maven build with the LOCAL-SNAPSHOT build.

Either that, or a way in our release script to verify that we are correctly shading everything.

@ronshapiro
Copy link
Author

This may now be as simple as just:

bazel test //...
bazel build //java/dagger/internal/codegen:new_bootstrap_compiler_deploy.jar
cp bazel-bin/java/dagger/internal/codegen/new_bootstrap_compiler_deploy.jar java/dagger/internal/codegen/bootstrap_compiler_deploy.jar
bazel test //...

@bcorso
Copy link

bcorso commented Jul 8, 2020

Closing this, since we added these tests a while ago, e.g. https://github.com/google/dagger/blob/master/util/run-local-tests.sh#L16-L33, and also a blaze rule for validation of deps, https://github.com/google/dagger/blob/master/tools/maven.bzl#L226

@bcorso bcorso closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants