Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cards-pane and tabbed-panes style import causes style overrides of Bootstrap card and Docsy highlight styles #1154

Closed
3 of 4 tasks
chalin opened this issue Aug 12, 2022 · 1 comment · Fixed by #1167
Closed
3 of 4 tasks
Assignees
Labels
bug Something isn't working design/style Front-end site design / styling

Comments

@chalin
Copy link
Collaborator

chalin commented Aug 12, 2022

The following PR

introduced an override of the Bootstrap styles for .card-deck, .card, etc. through shortcodes/cards-pane.scss. This style overrides is an undesirable breaking change.

My guess is that this problem was introduced way back via:

but that it wasn't as obviously manifested until cards-pane.scss got processed along with all other Bootstrap styles (as is done in #1009).

The card-related style changes should only be applied in the context of Docsy cards and card-decks.
@deining - do you agree?

Edit: this also happens for the .td-content .highlight Docsy style.

@chalin chalin added bug Something isn't working bootstrap labels Aug 12, 2022
@chalin chalin added design/style Front-end site design / styling and removed bootstrap labels Aug 12, 2022
@chalin chalin changed the title Recent change to tabbed-panes affects Bootstrap card styles cards-pane style import leaks over into Bootstrap card styles Aug 12, 2022
@chalin chalin changed the title cards-pane style import leaks over into Bootstrap card styles cards-pane and tabbed-panes style import causes style overrides of Bootstrap card and Docsy highlight styles Aug 12, 2022
@chalin
Copy link
Collaborator Author

chalin commented Aug 12, 2022

I've generalized this issue to cover tabbed-panes styles since the same unintention style override is happening for .td-content .highlight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design/style Front-end site design / styling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant