-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indentation in line-wrapped function arguments #12
Comments
Is there an ESLint rule for that? Otherwise you'll need to request it on the ESLint issue tracker. |
Apparently there is not, as I was unable to find one in the ESLint documentation (v2.11.1). Unfortunately, according to the ESlint contributing guide page, to request a new rule and for it to be accepted, you also need to be the one to create and maintain it. Currently I would be unable to do that. Wouldn't that be the case to create a custom rule for this configuration? |
That's not entirely correct. Open an issue and if there's merit to the idea, someone will come along and implement it. |
I just found that a parameter indentation rule is currently being evaluated by ESLint members. So it's just a question of time now. |
The indent rule has been updated to be more configurable. I found this repo while tweaking eslint configs for Google style. If you're still updating it, here's what I'm using for indentation so far:
I haven't sorted out what version of the Object Expression rule applies. |
Thanks for providing that snippet, @rachel-fenichel! I've added an object expression rule and submitted a PR: #50. |
Closing now that #50 is merged. |
According to the Google JavaScript Style:
This ESLint configuration (version 0.5.0) does not enforce that indentation. No warning is throw when I use less or more indentation in line-wrapped function arguments. By comparison the Closure Linter does this. It also throws indentation warnings on line-wrapped variable initializations and method chaining, which this ESLint configuration also does not enforce.
The text was updated successfully, but these errors were encountered: