Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with typescript-eslint #62

Open
IGassmann opened this issue Sep 14, 2019 · 5 comments
Open

Make it compatible with typescript-eslint #62

IGassmann opened this issue Sep 14, 2019 · 5 comments

Comments

@IGassmann
Copy link

Make eslint-config-google rules compatible with the TSLint replacement: typescript-eslint.

This will be valuable for TypeScript projects that follow the Google JavaScript Style Guide, such as Angular.

@Pringmore
Copy link

Hi @IGassmann

are there some news about configuring typescript-eslint:recommanded with eslint-config-google ?

@IGassmann
Copy link
Author

@Pringmore I wouldn't know. I'm not personally taking this initiative.

@loeffel-io
Copy link

+1

@43081j
Copy link

43081j commented Jun 6, 2020

If you extend both the recommend config and the eslint recommended config, it seems to work for me:

  "extends": [
    "google",
    "plugin:@typescript-eslint/eslint-recommended",
    "plugin:@typescript-eslint/recommended"
  ],

eslint-recommended disables a bunch of non-typescript rules which conflict with typescript equivalents.

@devinrhode2
Copy link

I think doing this is a great interim strategy:

  "extends": [
    "google",
    "plugin:@typescript-eslint/eslint-recommended",
    "plugin:@typescript-eslint/recommended"
  ],

But, it's quite un-satisfying, if you are a real TypeScript Junkie/fanboy/lover person. Maybe folks would be better off trying to use Angular core's config somehow, or using another eslint config altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants