From 409943b86cc0b6ec4b8b3f957938295a0e351cf6 Mon Sep 17 00:00:00 2001 From: Maximilien Dagois Date: Fri, 16 Aug 2024 11:43:06 +0900 Subject: [PATCH] Addressed some comments in the PR --- filament/backend/src/vulkan/VulkanDriver.cpp | 2 +- filament/backend/src/vulkan/VulkanTexture.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/filament/backend/src/vulkan/VulkanDriver.cpp b/filament/backend/src/vulkan/VulkanDriver.cpp index bee8258ac52a..43493bb1190e 100644 --- a/filament/backend/src/vulkan/VulkanDriver.cpp +++ b/filament/backend/src/vulkan/VulkanDriver.cpp @@ -1298,9 +1298,9 @@ void VulkanDriver::beginRenderPass(Handle rth, const RenderPassP if (rpkey.samples > 1) { const VulkanTexture* sidecar = info.texture->getSidecar(); assert_invariant(sidecar); + assert_invariant(sidecar->samples > 1); if (sidecar && sidecar->isTransientAttachment()) { rpkey.usesLazilyAllocatedMemory |= (1 << i); - assert_invariant(sidecar->samples > 1); } if (info.texture->samples == 1) { rpkey.needsResolveMask |= (1 << i); diff --git a/filament/backend/src/vulkan/VulkanTexture.cpp b/filament/backend/src/vulkan/VulkanTexture.cpp index fb171520e0e3..6c011d9e26f9 100644 --- a/filament/backend/src/vulkan/VulkanTexture.cpp +++ b/filament/backend/src/vulkan/VulkanTexture.cpp @@ -104,7 +104,7 @@ VulkanTexture::VulkanTexture(VkDevice device, VkPhysicalDevice physicalDevice, // Lazily allocated memory is available. context.isLazilyAllocatedMemorySupported() && // Usage consists of attachment flags only. - !any(tusage & ~TextureUsage::ALL_ATTACHMENTS) && + none(tusage & ~TextureUsage::ALL_ATTACHMENTS) && // Usage contains at least one attachment flag. any(tusage & TextureUsage::ALL_ATTACHMENTS); mIsTransientAttachment = useTransientAttachment;