Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you clarify whether a library should or should not declare flogger-system-backend dependency? #300

Open
suztomo opened this issue Nov 10, 2021 · 0 comments
Assignees
Labels
P3 type=documentation Documentation that is other than for an API

Comments

@suztomo
Copy link
Member

suztomo commented Nov 10, 2021

From the flogger documentation:

image

It says:

All code that uses flogger should depend on com.google.flogger:flogger: and com.google.flogger:flogger-system-backend:.

This is strange from my experience of slf4j and logback. If the relationship of flogger and flogger-system-backend is the same as slf4j and logback, then libraries that use flogger should not declare dependency on flogger-system-backend; otherwise the runtime that use multiple of these libraries may end up having different logging backends. http://www.slf4j.org/manual.html#libraries says:

Embedded components such as libraries or frameworks should not declare a dependency on any SLF4J binding but only depend on slf4j-api.

Would you add a similar guidance in flogger documentation?

@kluever kluever added P3 type=documentation Documentation that is other than for an API labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 type=documentation Documentation that is other than for an API
Projects
None yet
Development

No branches or pull requests

4 participants