LogSink::ToString has no microsecond precision.

[bmahler]

I noticed a custom LogSink was logging without microsecond precision:

I0330 16:05:21.000000 21188 master.cpp:8832] ...
I0330 16:05:21.000000 21188 master.cpp:8832] ...
I0330 16:05:21.000000 21188 master.cpp:8832] ...

Currently LogSink::ToString always uses 0 for the microsecond component of the timestamp. There is a FIXME related to this:

  // FIXME(jrvb): Updating this to use the correct value for usecs
  // requires changing the signature for both this method and
  // LogSink::send().  This change needs to be done in a separate CL
  // so subclasses of LogSink can be updated at the same time.
  int usecs = 0;

https://github.com/google/glog/blob/v0.3.5/src/logging.cc#L1631-L1635

Per the FIXME, it looks like the only way to fix this is by updating the signature of LogSink::send. Any third party LogSink implementations would need to have their signature adjusted. Would such a PR be acceptable?

[bmahler]

@sergiud I'm happy to send a PR for this, would you be willing to help me get it merged?

[sergiud]

@bmahler Sure, go ahead!

[sergiud]

Fixed in 5792d60.