Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace obsolete __CYGWIN64__ macro #566

Closed
adamroy opened this issue Jul 14, 2020 · 0 comments · Fixed by #611
Closed

Replace obsolete __CYGWIN64__ macro #566

adamroy opened this issue Jul 14, 2020 · 0 comments · Fixed by #611
Labels
bug
Milestone
0.5

Comments

@adamroy
Copy link

adamroy commented Jul 14, 2020

The macro __CYGWIN64__ should be replaced with __CYGWIN__ in src/base/mutex.h.

Cygwin documents that there is no __CYGWIN64__ macro: Cygwin FAQ

This was causing compilation issues for me due to include order problems, I think, when I was building https://github.com/mmp/pbrt-v3 (which includes glog).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

replaced __CYGWIN32__ and __CYGWIN64__ by __CYGWIN__ sergiud/glog
2 participants
@sergiud @adamroy