Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub/awssnssqs: URL scheme broken by go 1.12.8 #2647

Closed
vangent opened this issue Aug 14, 2019 · 0 comments · Fixed by #2648
Closed

pubsub/awssnssqs: URL scheme broken by go 1.12.8 #2647

vangent opened this issue Aug 14, 2019 · 0 comments · Fixed by #2648
Assignees
@vangent

Comments

@vangent
Copy link
Contributor

vangent commented Aug 14, 2019

It looks like the fix for golang/go#29098 in go 1.12.8 broke our URLs for this provider.

=== RUN   TestOpenTopicFromURL
--- FAIL: TestOpenTopicFromURL (0.00s)
    awssnssqs_test.go:436: awssns://arn:aws:service:region:accountid:resourceType/resourcePath: got error open pubsub.Topic: parse awssns://arn:aws:service:region:accountid:resourceType/resourcePath: invalid port ":resourceType" after host, want error false
@vangent vangent self-assigned this Aug 14, 2019
@vangent vangent mentioned this issue Aug 14, 2019
Merged
@vangent vangent added the in progress This is being actively worked on label Aug 14, 2019
@go-cloud-bot go-cloud-bot bot removed the in progress This is being actively worked on label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vangent vangent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pubsub/awssnssqs: fix docs/examples/tests to show SNS ARN in path, not hostname vangent/go-cloud
1 participant
@vangent