Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub/awssnssqs: duplicate key in map literal #3354

Closed
cadams93 opened this issue Dec 11, 2023 · 3 comments · Fixed by #3355
Closed

pubsub/awssnssqs: duplicate key in map literal #3354

cadams93 opened this issue Dec 11, 2023 · 3 comments · Fixed by #3355

Comments

@cadams93
Copy link

cadams93 commented Dec 11, 2023

Since a commit to the upstream aws-sdk-go library, the pubsub/awssnssqs package fails to build with the error:

../../../../../gocloud.dev/pubsub/awssnssqs/awssnssqs.go:987:2: duplicate key "AWS.SimpleQueueService.NonExistentQueue" in map literal

See: aws/aws-sdk-go#5101

This appears to be due to the introduction of buggyQueueNotFoundErrorCode as a solution to an unrelated SQS error handling issue: aws/aws-sdk-go-v2#2348 (see 53ccd8d#diff-657f9542b2a012c5bc40f808f592db272175a0cfade32cbe6eb7cb5112b40d70R987)

To Reproduce

  1. Create a basic application importing v0.35.0 (latest as of report).
  2. Update aws-sdk-go to latest main commit.
  3. Attempt to build the application.

Expected behavior

Sample application builds without error.

Version

Latest released v0.35.0.

Additional context

We discovered this issue in an application that is using GOPATH for dependency resolution. This will only be an issue present for users whose applications resolve to the latest aws-sdk-go release based on other explicit versioning requirements within the module - it will become an issue when gocloud.dev bumps the minimum version to include the aws-sdk-go change though. 😅

@cadams93 cadams93 changed the title pubsub/awssqssns: duplicate key in map literal pubsub/awssnssqs: duplicate key in map literal Dec 11, 2023
@vangent
Copy link
Contributor

vangent commented Dec 12, 2023

Grr. AWS is killing me.

@vangent
Copy link
Contributor

vangent commented Dec 12, 2023

aws/aws-sdk-go@87f2688

BREAKFIX is breaking my break fix.

@jufemaiz
Copy link

Dare I ask if a release is forthcoming ? v0.35.1 for example? 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants