You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am currently working with go-github sdk, and I noticed some inconsistencies in the types of time fields. Some fields are *time.Time while others are *Timestamp.
For example, this difference can be spotted in the PullRequest and Projects struct. It is also littered around the codebase. In my opinion, let's stick to one type for time fields which is *Timestamp.
if this is seen as a valid issue, I will open a PR to fix it.
Thanks.
The text was updated successfully, but these errors were encountered:
Thank you, @zombieleet .
It seems like there was a discussion about this before, but I'm not finding it.
Consistency would be nice, and I can't think of any downsides other than a boat-load of breaking API changes.
But that's why we version this, and people can hold back until they feel like upgrading.
I am currently working with
go-github
sdk, and I noticed some inconsistencies in the types of time fields. Some fields are*time.Time
while others are*Timestamp
.For example, this difference can be spotted in the PullRequest and Projects struct. It is also littered around the codebase. In my opinion, let's stick to one type for time fields which is
*Timestamp
.if this is seen as a valid issue, I will open a PR to fix it.
Thanks.
The text was updated successfully, but these errors were encountered: