You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context
We use the whenAllSucceed method in Futures to combine futures when batching requests. This is done for the "fast failing" that AggregateFuture provides.
When more than one future throws an exception, one of the exceptions gets propagated, but the others get logged here at SEVERE level. For our specific use case, the exceptions don't matter as much because we have retry logic on the server side to handle them.
Problem
We have monitoring in place for logging at the SEVERE level. As a result of the above behaviour, our monitors keep firing despite the server handling the retry logic correctly.
Proposed Solution
Could we make the logging level configurable?
It will need to be passed from AggregateFuture to CombinedFuture up to Futures#whenAllSucceed. It could be made optional, and if it isn't set then it falls back to SEVERE to preserve backwards compatibility.
The text was updated successfully, but these errors were encountered:
Context
We use the whenAllSucceed method in Futures to combine futures when batching requests. This is done for the "fast failing" that AggregateFuture provides.
When more than one future throws an exception, one of the exceptions gets propagated, but the others get logged here at SEVERE level. For our specific use case, the exceptions don't matter as much because we have retry logic on the server side to handle them.
Problem
We have monitoring in place for logging at the SEVERE level. As a result of the above behaviour, our monitors keep firing despite the server handling the retry logic correctly.
Proposed Solution
Could we make the logging level configurable?
It will need to be passed from AggregateFuture to CombinedFuture up to Futures#whenAllSucceed. It could be made optional, and if it isn't set then it falls back to SEVERE to preserve backwards compatibility.
The text was updated successfully, but these errors were encountered: