Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set-user/group-ID bits and executable file capabilities are not supported #213

Closed
amscanne opened this issue Apr 26, 2019 · 1 comment
Closed
Assignees
Labels
area: compatibility Issue related to (Linux) kernel compatibility exported Issue was exported automatically priority: p4 Very low priority type: cleanup Refactorings and cleanups to improve the code type: enhancement New feature or request

Comments

@amscanne
Copy link
Contributor

We currently use the syscall package for two different things:

  1. Enumerating constants for actually making system calls. E.g. syscall.Syscall(syscall.SYS_PWRITEV, ...).
  2. Some legacy constants for implementing a specific system interface (e.g. those that are still found in pkg/sentry/syscalls/linux).

We're moving to the abi/linux package for (2), but should also isolate cases for (1) in *_linux.go files and use the x/sys/unix package where possible.

@amscanne amscanne added area: compatibility Issue related to (Linux) kernel compatibility type: cleanup Refactorings and cleanups to improve the code type: enhancement New feature or request exported Issue was exported automatically priority: p4 Very low priority labels Apr 26, 2019
@amscanne
Copy link
Contributor Author

Whoops, bad export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compatibility Issue related to (Linux) kernel compatibility exported Issue was exported automatically priority: p4 Very low priority type: cleanup Refactorings and cleanups to improve the code type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants