Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KSP2] Can't find values in repeatable annotations #1883

Closed
kuanyingchou opened this issue May 10, 2024 · 3 comments
Closed

[KSP2] Can't find values in repeatable annotations #1883

kuanyingchou opened this issue May 10, 2024 · 3 comments
Assignees
Labels
AA waiting for upstream fix bug Something isn't working
Milestone

Comments

@kuanyingchou
Copy link
Collaborator

Getting the arguments of a repeatable annotation defined in both Java and Kotlin returns an empty list when the origin is KOTLIN_LIB.

Also when the annotation is defined in Kotlin it becomes a single Container, which is different from the expanded annotations in KSP1.

Repro: kuanyingchou@fc19f7d

@neetopia neetopia self-assigned this May 22, 2024
@neetopia neetopia added bug Something isn't working AA waiting for upstream fix labels May 22, 2024
@neetopia
Copy link
Contributor

This likely will need upstream fix.

@ZacSweers
Copy link
Contributor

@neetopia is there a youtrack link for upstream that we could follow?

@ting-yuan
Copy link
Collaborator

Fixed in #2041, where KSP unwraps the containers.

@ting-yuan ting-yuan added this to the 2.1 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AA waiting for upstream fix bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants