Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KSP2] Class values in type annotations get resolved to error type #1933

Closed
kuanyingchou opened this issue May 29, 2024 · 2 comments
Closed
Assignees
Labels
AA waiting for upstream fix bug Something isn't working
Milestone

Comments

@kuanyingchou
Copy link
Collaborator

This is similar to #1910. Class value is resolved to error type when the annotation is used on types and the origin is Java in KSP2, while it works in KSP1.

Repro: kuanyingchou@5580326

@neetopia neetopia self-assigned this May 29, 2024
@neetopia neetopia added the bug Something isn't working label May 29, 2024
@neetopia neetopia added this to the 2.1 milestone May 30, 2024
@neetopia
Copy link
Contributor

Issue is same as fix for this code:

This time however we can't fix it in KSP since it was resolved in AA already, we will need to fix the corresponding AA code for this https://github.com/JetBrains/kotlin/blob/71633b8e5ba49722170c9e06be87c058d11c985c/analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/evaluate/FirAnnotationValueConverter.kt#L192

@neetopia neetopia added the AA waiting for upstream fix label Jun 17, 2024
@ting-yuan ting-yuan assigned ting-yuan and unassigned neetopia Jul 12, 2024
@ting-yuan
Copy link
Collaborator

Fixed in AA as of build-2.1.0-dev-3498. JetBrains/kotlin@afbb511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AA waiting for upstream fix bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants