Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin which version of rust client to use when building the python package #714

Open
reyammer opened this issue Sep 23, 2024 · 1 comment
Open
Labels
python Pull requests that update Python package rust Pull requests that update Rust code

Comments

@reyammer
Copy link
Collaborator

The current python package build process just takes the latest rust binary we have under git. This is not ideal; we may want to select which specific version of the rust binary to pick for a given python package. For example, we may not want to use the latest v-*-rc.* rust binary, but we may want to pick a stable release.

We could implement this by improving the python build package script to do a clean checkout of a specific rust binary (rust releases should be tagged with rust-*, we could use those tags as reference points).

Regardless, I think it's important to decouple whatever rust's code "lives in main" and what we add to the python package.

@ia0, thoughts?

@reyammer reyammer added python Pull requests that update Python package rust Pull requests that update Rust code labels Sep 23, 2024
@ia0
Copy link
Member

ia0 commented Sep 23, 2024

Yes, I also thought about this issue, but thought that we would release Python and Rust "simultaneously" (i.e. first Rust and right after Python). In particular, Rust should always be in a releasable state, such that if we want to release Python, we just release Rust first. However, if we really want to release Python without releasing Rust first, then I guess we can do as you suggest (git checkout rust-xxx rust to overwrite the rust directory to a previous released version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python package rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

2 participants