Skip to content

Commit

Permalink
Always prelaunch converter/renderer on Windows 8+
Browse files Browse the repository at this point in the history
Currently mozc_broker{32, 64}.exe that is registered as a start-up task
tries to pre-launch mozc_{converter, renderer}.exe when and only when
Mozc is the default IME so as not to consume unnecessary resources.

However, if Mozc is not set to the default IME, the user would have no
idea why Mozc is not available until it is used at once in non-sanboxed
application.  With this CL, we always pre-launch those processes to
avoid confusions on Windows 8 and later.

BUG=
TEST=
REF_BUG=
REF_CL=131707250
REF_TIME=2016-08-30T23:26:23+09:00
REF_TIME_RAW=1472567183 +0900
  • Loading branch information
hiroyuki-komatsu committed Aug 30, 2016
1 parent ba51201 commit 0488082
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/data/version/mozc_version_template.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

MAJOR=2
MINOR=18
BUILD=2601
BUILD=2602
REVISION=102
# This version represents the version of Mozc IME engine (converter, predictor,
# etc.). This version info is included both in the Mozc server and in the Mozc
Expand Down
5 changes: 3 additions & 2 deletions src/win32/broker/prelauncher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

#include "base/logging.h"
#include "base/run_level.h"
#include "base/system_util.h"
#include "base/win_util.h"
#include "client/client_interface.h"
#include "renderer/renderer_client.h"
Expand Down Expand Up @@ -61,8 +62,8 @@ int RunPrelaunchProcesses(int argc, char *argv[]) {
return kErrorLevelGeneralError;
}

if (!ImeUtil::IsDefault()) {
// If Mozc is not default, do nothing.
if (!SystemUtil::IsWindows8OrLater() && !ImeUtil::IsDefault()) {
// If Mozc is not default on Windows 7 or former, do nothing.
return kErrorLevelSuccess;
}

Expand Down

0 comments on commit 0488082

Please sign in to comment.