From 20b02d2b06c5dfab7aa55c34ba77edef01e81afd Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Tue, 22 Oct 2024 09:55:32 +0900 Subject: [PATCH] Apply `buildifier` to existing files (#1090) Before we start applying lint checks for BUILD.bazel and *.bzl files in GitHub Actions (#1089), this commit aims to fix existing lint errors by actually applying 'buildifier' [1] locally. This is just a style fix in build files. There must be no observable behavior change in artifacts. [1]: https://github.com/bazelbuild/buildtools/ PiperOrigin-RevId: 688131325 --- src/bazel/BUILD.qt.bazel | 31 +++++++++++++++++-------------- src/bazel/BUILD.qt_win.bazel | 2 +- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/src/bazel/BUILD.qt.bazel b/src/bazel/BUILD.qt.bazel index 85459dce4..3b315131a 100644 --- a/src/bazel/BUILD.qt.bazel +++ b/src/bazel/BUILD.qt.bazel @@ -1,5 +1,8 @@ -load("@build_bazel_rules_apple//apple:apple.bzl", - "apple_dynamic_framework_import") +load( + "@build_bazel_rules_apple//apple:apple.bzl", + "apple_dynamic_framework_import", +) + package( default_visibility = ["//visibility:public"], ) @@ -11,42 +14,42 @@ package( cc_library( name = "qt_mac_core", hdrs = glob(["lib/QtCore.framework/Headers/*"]), + include_prefix = "QtCore", includes = [ - "lib/QtCore.framework/Headers", - "lib/QtCore.framework/Headers/QtCore", + "lib/QtCore.framework/Headers", + "lib/QtCore.framework/Headers/QtCore", ], - include_prefix = "QtCore", strip_include_prefix = "lib/QtCore.framework/Headers", ) cc_library( name = "qt_mac_gui", hdrs = glob(["lib/QtGui.framework/Headers/*"]), + include_prefix = "QtGui", includes = [ - "lib/QtGui.framework/Headers", - "lib/QtGui.framework/Headers/QtGui", + "lib/QtGui.framework/Headers", + "lib/QtGui.framework/Headers/QtGui", ], - include_prefix = "QtGui", strip_include_prefix = "lib/QtGui.framework/Headers", ) cc_library( name = "qt_mac_widgets", hdrs = glob(["lib/QtWidgets.framework/Headers/*"]), + include_prefix = "QtWidgets", includes = [ - "lib/QtWidgets.framework/Headers", - "lib/QtWidgets.framework/Headers/QtWidgets", + "lib/QtWidgets.framework/Headers", + "lib/QtWidgets.framework/Headers/QtWidgets", ], - include_prefix = "QtWidgets", strip_include_prefix = "lib/QtWidgets.framework/Headers", ) cc_library( name = "qt_mac", deps = [ - ":qt_mac_core", - ":qt_mac_gui", - ":qt_mac_widgets", + ":qt_mac_core", + ":qt_mac_gui", + ":qt_mac_widgets", ], ) diff --git a/src/bazel/BUILD.qt_win.bazel b/src/bazel/BUILD.qt_win.bazel index 10de745c0..c988a091f 100644 --- a/src/bazel/BUILD.qt_win.bazel +++ b/src/bazel/BUILD.qt_win.bazel @@ -25,7 +25,7 @@ cc_library( ], }), hdrs = glob([ - "include" + "include", ]), includes = [ "include",