Skip to content

Commit

Permalink
Use ".bzl" file extension in version template
Browse files Browse the repository at this point in the history
Basically Blaze/Bazel prefers ".bzl" for files to be included
from BUILD files.

BUG=
TEST=
REF_BUG=28131540
REF_CL=120517868
REF_TIME=2016-04-22T14:32:40+09:00
REF_TIME_RAW=1461303160 +0900
  • Loading branch information
kohyatoh committed Apr 22, 2016
1 parent 32a3854 commit ae6bbac
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/build_mozc.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def ParseGypOptions(args):
parser.add_option('--qtver', dest='qtver', choices=('4', '5'), default='4')
parser.add_option('--version_file', dest='version_file',
help='use the specified version template file',
default='data/version/mozc_version_template.txt')
default='data/version/mozc_version_template.bzl')
AddTargetPlatformOption(parser)

# Mac and Linux
Expand Down
2 changes: 1 addition & 1 deletion src/build_tools/mozc_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
Typically version definition file is ${PROJECT_ROOT}/mozc_version.txt
(Not in the repository because it is generated by this script)
Typically version template file is
${PROJECT_ROOT}/data/version/mozc_version_template.txt,
${PROJECT_ROOT}/data/version/mozc_version_template.bzl,
which is in the repository.
The syntax of template is written in the template file.
"""
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MAJOR=2
MINOR=18
BUILD=2555
BUILD=2556
REVISION=102
# CAUTION: NACL_DICTIONARY_VERSION is going to be migrated to ENGINE_VERSION.
# NACL_DICTIONARY_VERSION is the target version of the system dictionary to be
Expand Down
2 changes: 1 addition & 1 deletion src/data_manager/data_manager.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@
'action_name': 'gen_separate_version_data_for_<(dataset_tag)',
'variables': {
'generator': '<(mozc_dir)/data_manager/gen_data_version.py',
'version_file': '<(mozc_dir)/data/version/mozc_version_template.txt',
'version_file': '<(mozc_dir)/data/version/mozc_version_template.bzl',
},
'inputs': [
'<(generator)',
Expand Down

0 comments on commit ae6bbac

Please sign in to comment.