Skip to content

Commit

Permalink
Enable switching to DIRECT mode using the mouse. (#1061)
Browse files Browse the repository at this point in the history
This is about addressing the problem where selecting DIRECT with the mouse to switch input modes doesn't work.

In the PropertyHandler::ProcessPropertyActivate function, the processing for DIRECT mode is being skipped. This is because DIRECT=0 as defined in src/protocol/commands.proto#L51, so !entry->composition_mode is evaluated as true.
As a result, while the DIRECT menu item exists, it is not linked to the actual processing that should be executed for DIRECT.

PiperOrigin-RevId: 675589214
  • Loading branch information
phoepsilonix committed Sep 17, 2024
1 parent ff08a9c commit ff97bed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/unix/ibus/property_handler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ void PropertyHandler::ProcessPropertyActivate(IbusEngineWrapper *engine,

const MozcEngineProperty *entry =
prop.GetData<MozcEngineProperty>(kMozcEnginePropertyKey);
if (!entry || !entry->composition_mode) {
if (!entry) {
continue;
}
SetCompositionMode(entry->composition_mode);
Expand Down

0 comments on commit ff97bed

Please sign in to comment.