Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on 'dictionary/pos_matcher.h' from 'session/session_server.cc' is missing in GYP rules #380

Closed
yukawa opened this issue Aug 21, 2016 · 0 comments

Comments

@yukawa
Copy link
Collaborator

yukawa commented Aug 21, 2016

Environment

  • Mozc 2.17.2541.103 (ab513d0) and later

Steps to reproduce

  1. python build_mozc.py clean
  2. python build_mozc.py gyp
  3. python build_mozc.py build -c Release session/session.gyp:session_server

Expected behavior

Build succeeds.

Actual behavior

Build fails with the following error:

mozc_builder@e19b9db170df:~/work/mozc/src$ python build_mozc.py build -c Release session/session.gyp:session_server
INFO: Running: ninja -C out_linux/Release session_server
ninja: Entering directory `out_linux/Release'
[165/186] CXX obj/session/session_server.session_server.o
FAILED: obj/session/session_server.session_server.o 
/usr/bin/clang++ -MMD -MF obj/session/session_server.session_server.o.d -DOS_LINUX -DMOZC_BUILD -DCHANNEL_DEV -DENABLE_GTK_RENDERER -DNDEBUG -DQT_NO_DEBUG -DNO_LOGGING -DIGNORE_HELP_FLAG -DIGNORE_INVALID_FLAG -I/home/mozc_builder/work/mozc/src -Igen -Igen/proto_out -I../../third_party/protobuf/src -Wall -Wno-char-subscripts -Wno-sign-compare -Wno-deprecated-declarations -Wwrite-strings -fPIC -fno-exceptions -fmessage-length=0 -fno-strict-aliasing -funsigned-char -include base/namespace.h -pipe -pthread -fno-omit-frame-pointer -fstack-protector --param=ssp-buffer-size=4 -Wtype-limits -O2 -Wno-deprecated -Wno-covered-switch-default -Wno-unnamed-type-template-args -Wno-c++11-narrowing -std=gnu++0x -std=gnu++0x  -c ../../session/session_server.cc -o obj/session/session_server.session_server.o
In file included from ../../session/session_server.cc:39:
In file included from /home/mozc_builder/work/mozc/src/engine/engine_factory.h:34:
In file included from /home/mozc_builder/work/mozc/src/engine/oss_engine_factory.h:34:
/home/mozc_builder/work/mozc/src/engine/engine.h:39:10: fatal error: 'dictionary/pos_matcher.h' file not found
#include "dictionary/pos_matcher.h"
         ^
1 error generated.

Additional information

This issue is a regression introduced by ab513d0. Since we generate dictionary/pos_matcher.h at build time, the dependency needs to be declared in GYP rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant