Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUAWEI P9 lite does not show MozcView. #384

Closed
justoneplanet opened this issue Sep 13, 2016 · 3 comments
Closed

HUAWEI P9 lite does not show MozcView. #384

justoneplanet opened this issue Sep 13, 2016 · 3 comments
Assignees

Comments

@justoneplanet
Copy link

Devices

  • HUAWEI P9 lite: HUAWEI VNS-L22

What steps will reproduce the problem?

  1. Start typing on the any text fields.

What is the expected output?

MozcView will be shown.

What do you see instead?

Nothing will be shown.

What version of the product are you using? On what operating system?

Android 6.0
mozc 1.15.1917.103

Please provide any additional information below.

The following lines will fix this problem.

-    super(base.getAssets(), null, null);
+    super(base.getAssets(), base.getDisplayMetrics(), base.getConfiguration());

like following...

On the HwResources class of HUAWEI VNS-L22, density property of DisplayMetrics, which is set on the constructor, will be accessed. It seems that causes NullPointerException.

@yukawa
Copy link
Collaborator

yukawa commented Sep 14, 2016

Thank you for the report!

Looks like you are talking about src/android/src/com/google/android/inputmethod/japanese/util/ResourcesWrapper.java , right?

If so seem that we can simply use android.support.v7.widget.ResourcesWrapper rather than keeping maintaining our own version of ResourcesWrapper.

@justoneplanet
Copy link
Author

Looks like you are talking about src/android/src/com/google/android/inputmethod/japanese/util/ResourcesWrapper.java , right?

Yes!

If so seem that we can simply use android.support.v7.widget.ResourcesWrapper
rather than keeping maintaining our own version of ResourcesWrapper.

I think so, but this class in the support library is not public.😢

@yukawa
Copy link
Collaborator

yukawa commented Sep 14, 2016

I think so, but this class in the support library is not public.:cry:

Ah, I see. Then fixing org.mozc.android.inputmethod.japanese.util.ResourcesWrapper makes sense. Will update this thread when it is done.

Thanks!

@yukawa yukawa closed this as completed in 461297a Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants