-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mtail] Can't figure out how to make coverage build work #3293
Comments
As per the log from https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19640#c14, it looks like the build itself succeeds (i.e. compilation), but somehow your fuzz target doesn't produce any coverage dumps. |
Ah, this is Go project. Sorry, coverage for Go is not yet supported. We have a workaround that should have prevented coverage failure being reported to you, but it doesn't work because of the reason mentioned in #3297 TL;DR: sorry for the noise, we should not have reported that as an error, and we will fix it as soon as we agree on #3297. |
Great, thanks. I can't seem to close the bug as wontfix, is that possible?
…On Tue, 28 Jan 2020 at 09:55, Max Moroz ***@***.***> wrote:
Ah, this is Go project. Sorry, coverage for Go is not yet supported. We
have a workaround that should have prevented coverage failure being
reported to you, but it doesn't work because of the reason mentioned in
#3297 <#3297>
*TL;DR*: sorry for the noise, we should not have reported that as an
error, and we will fix it as soon as we agree on #3297
<#3297>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3293?email_source=notifications&email_token=AAXFX6ZOAJ2TSS2SFZFCWTTQ75Q7PA5CNFSM4KLUYXK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKBMIHA#issuecomment-578995228>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXFX6ZGZQPNAMCXR2TWAT3Q75Q7PANCNFSM4KLUYXKQ>
.
|
I can WontFix it but I'm not sure it won't come back again until we fix #3297. Good news is that we'll address it soon, and https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19640 will get auto-closed. |
Thanks!
…On Tue, 28 Jan 2020 at 10:16, Max Moroz ***@***.***> wrote:
I can WontFix it but I'm not sure it won't come back again until we fix
#3297 <#3297>. Good news is that
we'll address it soon, and
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19640 will get
auto-closed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3293?email_source=notifications&email_token=AAXFX65TVBZAXHEKXVECPSLQ75TM7A5CNFSM4KLUYXK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKBN4GY#issuecomment-579001883>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXFX62XKOCZZJA3TFRWCLLQ75TM7ANCNFSM4KLUYXKQ>
.
|
Can you help me figure out what's wrong here?
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19640
The build.sh is assuming all the environment variables are passed through to the makefile, which works for the sanitizer, but not coverage, and now I assume there's an environment variable missed but can't figure it out.
The text was updated successfully, but these errors were encountered: