Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mtail] Can't figure out how to make coverage build work #3293

Closed
jaqx0r opened this issue Jan 26, 2020 · 5 comments
Closed

[mtail] Can't figure out how to make coverage build work #3293

jaqx0r opened this issue Jan 26, 2020 · 5 comments

Comments

@jaqx0r
Copy link
Contributor

jaqx0r commented Jan 26, 2020

Can you help me figure out what's wrong here?

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19640

The build.sh is assuming all the environment variables are passed through to the makefile, which works for the sanitizer, but not coverage, and now I assume there's an environment variable missed but can't figure it out.

@Dor1s
Copy link
Contributor

Dor1s commented Jan 27, 2020

As per the log from https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19640#c14, it looks like the build itself succeeds (i.e. compilation), but somehow your fuzz target doesn't produce any coverage dumps.

@Dor1s
Copy link
Contributor

Dor1s commented Jan 27, 2020

Ah, this is Go project. Sorry, coverage for Go is not yet supported. We have a workaround that should have prevented coverage failure being reported to you, but it doesn't work because of the reason mentioned in #3297

TL;DR: sorry for the noise, we should not have reported that as an error, and we will fix it as soon as we agree on #3297.

@Dor1s Dor1s closed this as completed Jan 27, 2020
@jaqx0r
Copy link
Contributor Author

jaqx0r commented Jan 27, 2020 via email

@Dor1s
Copy link
Contributor

Dor1s commented Jan 27, 2020

I can WontFix it but I'm not sure it won't come back again until we fix #3297. Good news is that we'll address it soon, and https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19640 will get auto-closed.

@jaqx0r
Copy link
Contributor Author

jaqx0r commented Jan 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants