[Go] remove "-lpthread" flag from "compile_fuzzer" and fix comments (#2714). #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
approved these changes
Apr 16, 2020
|
Also fixed gonids and go-dns builds. |
|
Hey @Dor1s, TravisBuddy Request Identifier: 0e9a4610-7fae-11ea-8584-e9567e2fd09d |
inferno-chromium
approved these changes
Apr 16, 2020
projects/golang/build.sh
Outdated
| # Copy the fuzzer binary | ||
| cp fuzzer-$fuzzer $OUT | ||
| # Copy the fuzzer binary | ||
| cp fuzzer-$fuzzer $OUT |
There was a problem hiding this comment.
nit: i think these two cps can be removed by adding $OUT/ as prefix in the two commands.
| } | ||
|
|
||
| compile_fuzzer /root/go/src/github.com/google/gonids/ FuzzParseRule fuzz_parserule | ||
| compile_fuzzer github.com/google/gonids FuzzParseRule fuzz_parserule |
There was a problem hiding this comment.
You might want to remove RUN go get github.com/google/gonids from Dockerfile.
There was a problem hiding this comment.
Why? I think that commands checks out the project to fuzz
|
Hey @Dor1s, TravisBuddy Request Identifier: 37d41fc0-8002-11ea-a591-33c228b1c119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like it isn't needed anymore, or maybe it was never needed and I mistakenly added it in the first place.
Also fixed
gonidsandgo-dnsbuilds, they had import errors.