Skip to content

Latest commit

 

History

History
181 lines (132 loc) · 5.61 KB

CONTRIBUTING.md

File metadata and controls

181 lines (132 loc) · 5.61 KB
Raw

How to Contribute

We'd love to accept your patches and contributions to this project. There are just a few small guidelines you need to follow.

Contributor License Agreement

Contributions to this project must be accompanied by a Contributor License Agreement. You (or your employer) retain the copyright to your contribution; this simply gives us permission to use and redistribute your contributions as part of the project. Head over to https://cla.developers.google.com/ to see your current agreements on file or to sign a new one.

You generally only need to submit a CLA once, so if you've already submitted one (even if it was for a different project), you probably don't need to do it again.

Code reviews

All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult GitHub Help for more information on using pull requests.

Community Guidelines

This project follows Google's Open Source Community Guidelines.

Contributing code

Prerequisites

You must install:

  1. Git
  2. Python 3.11
  3. Docker
  4. Pylint
  5. Yapf
  6. Make
  7. Poetry
  8. Google Cloud SDK
  9. Hugo
  10. Node JS >= 18.17.x
  11. Terraform >= 1.5 (for infrastructure changes)

Then you can set up the development environment by cloning the OSV repo and installing the Poetry dependencies.

git clone --recurse-submodules https://github.com/google/osv.dev
# FYI
# git config fetch.recurseSubmodules on-demand
# is recommended to help manage updates to the osv/osv-schema submodule
cd osv.dev
poetry install
poetry shell

Running tests

Certain tests require you to auth with the Google Cloud SDK and to install the Datastore Emulator:

gcloud auth login --update-adc
gcloud components install beta cloud-datastore-emulator

To run tests:

make all-tests

To run integration tests for the API is a separate command

make api-server-tests

By default, this skips long tests, enable them by setting the LONG_TESTS variable

LONG_TESTS=1 make api-server-tests

Test result generation

Many tests are written using a simple framework to help with generating expected test outputs.

The expected outputs are generated once and saved into the source tree to run all subsequent tests against.

If a change is made that requires these outputs to be regenerated, you can set the environment variable TESTS_GENERATE=1 and run the tests:

TESTS_GENERATE=1 make all-tests

Linting and formatting

To lint your code, run

make lint

To format your code, run

yapf -i <file>.py

Running local UI and API instances (maintainers only)

UI

gcloud auth login --update-adc
make run-appengine

API

Running a local instance of the API server requires the path to application default credentials. The is required so that the ESP container has credentials to download API configuration.

gcloud auth login --update-adc
make run-api-server

Making commits

Please follow the Conventional Commits specification for commit messages. This helps us to automate processes like changelog generation and ensures a clear and consistent commit history.

Some types: feat:, fix:, docs:, chore:, refactor:, and others.

Contributing data

Data contributions are also welcome!

If you a work with a project such as a Linux distribution and would like to contribute your security advisories, please follow these steps.

  1. Open an issue. Let us know about your project and we can help you figure out the remaining steps. Please tag the issue datasource so we can properly triage the issue.

  2. Refer to the OSV Schema documentation for information on how to properly format the data so it can be accepted.

  3. Data can be supplied either through a public Git repository, a public GCS bucket or to REST API endpoints.

Contributing documentation

Please follow these steps to successfully contribute documentation.

  1. Fork the repository.
  2. Make desired documentation changes.
  3. Preview the changes by spinning up a GitHub page for your fork, building from your working branch.
    • On your fork, go to the settings tab and then the GitHub page settings. Sample URL: https://github.com/{your-github-profile}/osv.dev/settings/pages
    • Under "Build and deployment" select "Build from branch"
    • Set the branch to your working branch
    • Set the github page to build from the "/docs" folder
    • Hit save and wait for your site to build
    • Once it is ready, click the link and preview the docs

Image shows the UI settings for building the GitHub page, which is described in step 3 of the contributing documentation instructions.

  1. If you are satisfied with the changes, open a PR
  2. In the PR, link to your fork's GitHub page, so we can preview the changes