-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Node 17 and 18. Drop support for Node 10, 12 and 15. #170
Comments
Revisiting this issue now. Updating the title so it matches the current releases of node. The plan is to update the tests for node 17 and 18 and drop tests for node 10 and 15. Would also like to note that since we use A workaround is to use the |
Given this, the approach for generating pre-built binaries will need to change to build binaries for Node 18. |
Might be possible to switch to using Node.js's inspector & drop the native portion of this library once LTS for Node 12 has ended. |
Should also update the docs here https://cloud.google.com/profiler/docs/profiling-nodejs |
Would it be possible to cut a release to have Node 18 support on the latest stable version? Thanks. |
This library works fine on node 18 already. The only issue is we can't supply pre-built binaries. Are you seeing a specific issue @pietrodn ? |
Sorry, I realized that somehow the binary I had in |
Should this not have 20 as well now? |
would love to see support for node@20 |
It should work fine in node 20 already. Please see #273 (comment), for more info. |
I'm going to close this as fixed since we support up to Node 20. The only part of this issue still missing is the pre-built binaries, which I will open a separate issue for. |
Node 17 will be released on 6/1. Support for Node 15 will end on that day.
We should add tests and pre-built binarys for Node 17, and remove tests and prebuilt binaries for Node 15 then.
The text was updated successfully, but these errors were encountered: