Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node 17 and 18. Drop support for Node 10, 12 and 15. #170

Closed
nolanmar511 opened this issue May 26, 2021 · 11 comments
Closed
Assignees

Comments

@nolanmar511
Copy link
Contributor

nolanmar511 commented May 26, 2021

Node 17 will be released on 6/1. Support for Node 15 will end on that day.

We should add tests and pre-built binarys for Node 17, and remove tests and prebuilt binaries for Node 15 then.

@nolanmar511 nolanmar511 self-assigned this May 26, 2021
@nolanmar511 nolanmar511 changed the title Add support for Node 17 Add support for Node 17 and drop support for Node 15 May 26, 2021
@amchiclet
Copy link
Contributor

amchiclet commented Apr 29, 2022

Revisiting this issue now. Updating the title so it matches the current releases of node.

The plan is to update the tests for node 17 and 18 and drop tests for node 10 and 15.

Would also like to note that since we use source-map, the tests for node 18 will fail until the upstream issue is officially fixed.

A workaround is to use the 0.8.0-beta.0 version of source-map.

@amchiclet amchiclet changed the title Add support for Node 17 and drop support for Node 15 Add support for Node 17 and 18. Drop support for Node 10 and 15. Apr 29, 2022
@nolanmar511 nolanmar511 changed the title Add support for Node 17 and 18. Drop support for Node 10 and 15. Add support for Node 17 and 18. Drop support for Node 10, 12 and 15. Jun 14, 2022
@nolanmar511
Copy link
Contributor Author

node-pre-gyp does not currently have maintainers (mapbox/node-pre-gyp#657) and does not support building node 18 binaries on a machine using another version of node (mapbox/node-pre-gyp#647).

Given this, the approach for generating pre-built binaries will need to change to build binaries for Node 18.

@nolanmar511
Copy link
Contributor Author

Might be possible to switch to using Node.js's inspector & drop the native portion of this library once LTS for Node 12 has ended.

@aabmass
Copy link
Member

aabmass commented Oct 27, 2022

Should also update the docs here https://cloud.google.com/profiler/docs/profiling-nodejs

@pietrodn
Copy link

Would it be possible to cut a release to have Node 18 support on the latest stable version? Thanks.

@aabmass
Copy link
Member

aabmass commented Jun 14, 2023

This library works fine on node 18 already. The only issue is we can't supply pre-built binaries. Are you seeing a specific issue @pietrodn ?

@pietrodn
Copy link

Sorry, I realized that somehow the binary I had in node_modules was built against the wrong Node runtime. A reinstall did the trick.

@ericwooley
Copy link

Should this not have 20 as well now?

@franleplant
Copy link

would love to see support for node@20 20

@aabmass
Copy link
Member

aabmass commented Feb 1, 2024

It should work fine in node 20 already. Please see #273 (comment), for more info.

@aabmass
Copy link
Member

aabmass commented Sep 17, 2024

I'm going to close this as fixed since we support up to Node 20. The only part of this issue still missing is the pre-built binaries, which I will open a separate issue for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants