Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature "requiring from the command line" #234

Open
aabmass opened this issue Nov 2, 2022 · 0 comments
Open

Remove feature "requiring from the command line" #234

aabmass opened this issue Nov 2, 2022 · 0 comments
Assignees

Comments

@aabmass
Copy link
Member

aabmass commented Nov 2, 2022

See https://github.com/google/pprof-nodejs#requiring-from-the-command-line

In #227 (comment) we discussed how moving to inspector API for time profiling makes the stop() method async. Since stop() is being run in a process.on('exit') handler, it can't be async and will fail in the new form.

This code is not used by the profiler agent so it should be safe to remove. If there are FRs to add it back, maybe beforeExit event would be a decent middleground, or we can add a bunch of signal handlers to run stop() before shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant