Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 12 #66

Closed
nolanmar511 opened this issue May 23, 2019 · 2 comments
Closed

Support Node 12 #66

nolanmar511 opened this issue May 23, 2019 · 2 comments
Assignees
@nolanmar511

Comments

@nolanmar511
Copy link
Contributor

Right now, this is blocked because binaries won't build when using 12.3.0 (because of nodejs/node#27803), and the Node 12 alpine image currently uses 12.3.0.

But, in a couple days, I assume that will be sorted out, and otherwise pprof-nodejs seems to be working with Node 12.
@kalyanac kalyanac added the blocked Progress blocked by another issue label May 28, 2019
@nolanmar511 nolanmar511 removed the blocked Progress blocked by another issue label Jun 3, 2019
@nolanmar511
Copy link
Contributor Author

The latest node:12-alpine image uses 12.3.1.

So this is unblocked there.

@nolanmar511 nolanmar511 mentioned this issue Jun 11, 2019
Merged
@nolanmar511 nolanmar511 changed the title Publish Pre-built binaries for Node 12 Support Node 12 Jul 18, 2019
@nolanmar511
Copy link
Contributor Author

The agent has been released since #70, so prebuilt binaries are available.

However, we're still blocked on setting up unit testing by googleapis/google-cloud-node#2923.

I re-purposed this issue to be a bit more general and capture supporting Node 12 in pprof-nodejs (which, I think, requires getting unit tests working).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nolanmar511 nolanmar511

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kalyanac @nolanmar511