Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-symbolizer 13.0.0 may have YAML output #606

Closed
MaskRay opened this issue Feb 12, 2021 · 2 comments
Closed

llvm-symbolizer 13.0.0 may have YAML output #606

MaskRay opened this issue Feb 12, 2021 · 2 comments

Comments

@MaskRay
Copy link
Contributor

MaskRay commented Feb 12, 2021

https://reviews.llvm.org/D96289 proposes to add YAML output to llvm-symbolizer. I still need to convince myself that the output is useful. Since pprof parses llvm-symbolizer output (internal/binutils/addr2liner_llvm.go) I think you may have an opinion on it:)

@aalexand
Copy link
Collaborator

I don't think there is an out of the box YAML parser in Golang, so this is not interesting as this would require an additional dependency or custom parsing both of which are not exciting.

Do you know why YAML was chosen? JSON is a more common choice for machine-readable output. YAML is used more as a configuration language - i.e. human-read and -written.

@aalexand
Copy link
Collaborator

Also, frankly, even if it would be JSON, I don't see us switching to it. There isn't a lot of parsing code as the format is pretty simple and switching to JSON would still require supporting the old parsing code as well so why bother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants