From 2b5da08f77f06228e8ca30225469a78078c43710 Mon Sep 17 00:00:00 2001 From: Evan Mattson Date: Tue, 10 Sep 2024 22:44:46 -0400 Subject: [PATCH 1/2] Add dry run as step. --- .github/workflows/zips.yml | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/.github/workflows/zips.yml b/.github/workflows/zips.yml index e1779bf122f..fa85f716de3 100644 --- a/.github/workflows/zips.yml +++ b/.github/workflows/zips.yml @@ -65,11 +65,6 @@ on: description: Release version required: false default: '' - dry_run: - type: boolean - description: Run the publishing process without committing. - required: false - default: false concurrency: group: zips-${{ github.event_name }}-${{ github.ref }} @@ -223,6 +218,29 @@ jobs: edit-mode: replace body: Build files for ${{ github.event.pull_request.head.sha }} have been deleted. + dryrun-publish-to-wporg: + name: '[DRY RUN] Publish to WordPress.org' + runs-on: ubuntu-latest + environment: github-pages # no SVN credentials! + if: github.event_name == 'workflow_dispatch' && ( github.ref_type == 'tag' || inputs.release_version != '' ) + steps: + - uses: actions/download-artifact@v4 + with: + name: zip-files + path: /tmp + - name: Extract + run: | + unzip /tmp/google-site-kit.zip + - uses: 10up/action-wordpress-plugin-deploy@2.2.2 + with: + dry-run: true + env: + BUILD_DIR: ./google-site-kit + SLUG: google-site-kit + SVN_PASSWORD: no-op-password + SVN_USERNAME: no-op-username + VERSION: ${{ inputs.release_version }} + publish-to-wporg: name: Publish to WordPress.org runs-on: ubuntu-latest @@ -240,7 +258,7 @@ jobs: unzip /tmp/google-site-kit.zip - uses: 10up/action-wordpress-plugin-deploy@2.2.2 with: - dry-run: ${{ inputs.dry_run }} + dry-run: false env: BUILD_DIR: ./google-site-kit SLUG: google-site-kit From 93d3cc0a83d36f9f31347814a4084ae77f01ed9a Mon Sep 17 00:00:00 2001 From: Evan Mattson Date: Wed, 11 Sep 2024 14:18:55 -0400 Subject: [PATCH 2/2] Update dry-run job definition. --- .github/workflows/zips.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/zips.yml b/.github/workflows/zips.yml index fa85f716de3..3868bf71b03 100644 --- a/.github/workflows/zips.yml +++ b/.github/workflows/zips.yml @@ -221,8 +221,10 @@ jobs: dryrun-publish-to-wporg: name: '[DRY RUN] Publish to WordPress.org' runs-on: ubuntu-latest - environment: github-pages # no SVN credentials! + # environment: do not define to omit SVN credentials + deployment protection rules for this dry-run. if: github.event_name == 'workflow_dispatch' && ( github.ref_type == 'tag' || inputs.release_version != '' ) + needs: build-zips + timeout-minutes: 20 steps: - uses: actions/download-artifact@v4 with: @@ -257,8 +259,6 @@ jobs: run: | unzip /tmp/google-site-kit.zip - uses: 10up/action-wordpress-plugin-deploy@2.2.2 - with: - dry-run: false env: BUILD_DIR: ./google-site-kit SLUG: google-site-kit