-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip overlapping the header #5938
Comments
@asvinb The tooltip you have shown is really a one-off feature tour (without the backdrop) which should be on a higher plane than pretty much everything else. If we want a different behavior in this case, we should maybe have a more "inline" version of this or perhaps add a class to this instance specifically which reduces its z-index rather than lowering it for all which would break tours that highlight elements of the header/navigation, for example. |
@aaemnnosttv Agree with not lowering the tooltip z-index globally but instead changing the z-index only to be lower than the header z-index only for this tour. |
ACs are good 👍🏻 |
IB ✔️ |
QA Update: ❌@sashadoes I have an observation that I'd like to run by you. All looks good on small screen sizes like mobile and tablet, but on desktop when I scroll down, the tooltip shifts placement and now it doesn't overlap the WordPress side menu, and looks a little odd. This is 1.92.0 the latest release This is how I see it now on the develop branch Interested in your thoughts here, but in my opinion, I do think it should overlap on the side menu. |
QA Update: ✅Verified:
Note: I did discover a styling issue on small screen sizes related to the tooltip but it wasn't a regression related to this ticket, so will create a separate ticket for it. |
Bug Description
Currently tooltips have a very high
z-index
(20000) which results in them being on top of other elements on the page. However we have an issue with sticky elements where there is an overlap. This is the case with the header where on small screens, upon scrolling the page, the tooltip overlaps the header.Steps to reproduce
Screenshots
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/js/modules/analytics/components/settings/GA4SettingsControls.js
,JoyrideTooltip
to include thestyles
prop with the following value:Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: