Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA4 Widgets: Update "Engaged Sessions" metric name title to read "Engagement rate". #6693

Closed
techanvil opened this issue Mar 7, 2023 · 4 comments
Labels
Module: Analytics Google Analytics module related issues P0 High priority Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Mar 7, 2023

Feature Description

As discussed on Slack, having switched from the engagedSessions metric to engagementRate, we should also update the relevant titles on the GA4 widgets that use it, from "Engaged Sessions" to "Engagement rate".


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • All GA4 widgets that present the engagementRate metric should use "Engagement Rate" for the corresponding metric name/column title.

Implementation Brief

  • Using ModulePopularPagesWidgetGA4, extract-dashboard-data.js, overall-page-metrics.js, SearchFunnelWidgetGA4:
    • Locate 'Engaged Sessions' and change it to 'Engagement Rate'
  • In the case of ModulePopularPagesWidgetGA4 and SearchFunnelWidgetGA4, also change the ID from engaged-sessions to engagement-rate. This isn't part of the ACs but helps with consistency.

Test Coverage

  • No new tests are needed; VRTs might need updating for the new metric title.

QA Brief

  • Enable ga4Reporting and check the Widgets mentioned in the AC for the change from 'Engaged Sessions' to 'Engagement Rate'.

Changelog entry

  • Update the "Engaged Sessions" metric title to read "Engagement Rate" in the new GA4 widgets.
@techanvil techanvil added Module: Analytics Google Analytics module related issues P0 High priority Type: Enhancement Improvement of an existing feature labels Mar 7, 2023
@sashadoes sashadoes self-assigned this Mar 7, 2023
@sashadoes sashadoes removed their assignment Mar 7, 2023
@tofumatt tofumatt self-assigned this Mar 7, 2023
@tofumatt
Copy link
Collaborator

tofumatt commented Mar 7, 2023

All of the existing metrics, as well as metrics in the GA4 Figma mock, use Title Case for their names:

CleanShot 2023-03-07 at 23 39 29

CleanShot 2023-03-07 at 23 39 22

I'm guessing "Engagement rate" here was an oversight and not something deliberate; if it wasn't and we want to change the case of these metrics it might be better to do that all at once—it will be confusing having them be inconsistent.

I've adjusted the case in the ACs and IB, and pinged @techanvil just to make sure it wasn't intentional.

IB ✅

@tofumatt tofumatt removed their assignment Mar 7, 2023
@techanvil
Copy link
Collaborator Author

Thanks @tofumatt - good spot, it should indeed be "Engagement Rate".

@techanvil
Copy link
Collaborator Author

Note that while reviewing the PR for this issue I noticed the SearchFunnelWidgetGA4 component is still using engagedSessions rather than engagementRate for the underlying report, and is not displaying Engagement Rate as a percentage in the UI. I have created #6724 to address this.

@techanvil techanvil removed their assignment Mar 14, 2023
@mohitwp mohitwp self-assigned this Mar 14, 2023
@mohitwp
Copy link
Collaborator

mohitwp commented Mar 15, 2023

QA Update ✅

  • Tested on dev environment.
  • Tested widgets on both main and entity dashboard.
  • Verified ModulePopularPagesWidgetGA4 , SearchFunnelWidgetGA4 and DashboardOverallPageMetricesWidgetGA4.
  • Verified- All GA4 widgets that present the engagementRate metric should use "Engagement Rate" for the corresponding metric name/column title.
  • Also, tested GA4 components using react developer tool.

Note -

  1. I've found that on entity dashboard when user clicks on engagement rate and unique visitors from search data then it creates fatal error. I will create a separate issue for this.

image

  1. The Engagement Rate metric is currently shown in the SearchFunnelWidgetGA4 component without the percentage sign. This will resolve in a separate issue - Fix Engagement Rate in the SearchFunnelWidgetGA4 component. #6724

image

image

image

image

image

image

@mohitwp mohitwp removed their assignment Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues P0 High priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants