-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the placeholder tile variants of the Audience Tile #8146
Comments
Hi @ankitrox, thanks for drafting this IB. I started making an amendment to rename
It's worth mentioning these default audiences can be determined by having the
This link is out of date, the code has moved to the |
Thank you @techanvil for reviewing the IB. Your changes in grammatical mistakes looks all good, thanks for correcting it. I have updated the couple of points mentioned by you so that IB is again ready for your review. Thanks |
Thanks @ankitrox, that's great. The IB LGTM. ✅ |
QA Update ✅
Verified -
Verified
|
Feature Description
Implement the placeholder tile variants of the Audience Tile that are displayed when only one tile is selected.
See audience tiles > placeholder tiles in the design doc.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
PlaceholderTile
inassets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTile/
Widget
- This component is already available inAudienceTilesWidget
and can be directly passed to thePlaceholderTile
component.availableAudiences
- List of available audiences in Google Analytics.configuredAudiences
- List of configured audiences (saved audiences to display) in Site Kit dashboard.configuredAudiences
fromavailableAudiences
and check if there are any non-default audiences available in the filtered list. Default audiences can be determined by having theaudienceType
value ofDEFAULT_AUDIENCE
in the list ofavailableAudiences
, any audiences apart from these will be non-default audiences. Store the result innonDefaultAudiencesAvailable
.nonDefaultAudiencesAvailable
istrue
.title
and assign the valueCompare your group to other groups
.description
and assign the valueSelect another group to compare with your current group or learn more about how to group site visitors in Analytics
.createInterpolateElement
to form the description with the link.Select
link will be a component and clicking it should open the audience selection panel. Refer to theChangeGroupsLink
component for how to open of the selection panel from a link.Analytics
link, make use of thegetGoogleSupportURL
selector from thecore/site
store. Pass thepath
parameter asanalytics/answer/12799087
. A similar example can be found here.nonDefaultAudiencesAvailable
isfalse
.title
and assign the valueCreate more visitor groups
.description
and assign the valueLearn more about how to group site visitors in Analytics
. Make usecreateInterpolateElement
as state above.assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidet.js
.visibleAudiences
is one, if it is one, render thePlaceholderTile
component with the mentioned props.Test coverage
PlaceHolderTile
component for both the cases mentioned in AC.QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: