-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Ads
Module Site Health Checks
#8245
Comments
@10upsimon, the current AC is more like IB. We don't need to go into that much details there. Just top level requirements should be added that describe the final result instead of how we need to do it. In the context of the current ticket, the final results are that we display site health information for the Ads module and it shows conversion id and whether the snippet information. I think we don't even need to declare which class we need to implement in the module class because that is a part of IB after all (i know that we did it like this in other tickets, but that is excessive i think). |
@eugene-manuilov this is back with you, greatly simplified |
Yeah, AC 🌶️ |
IB ✔️ |
Hi @10upsimon, As discussed on Slack, the QAB needs to be updated. Can you please update it and set the Update: Let's set this ticket blocked by #8348. Hence we don't need |
Flagging that this is still blocked until we have #8251 merged. It's pending merge of that purely from a setup perspective so that we do not need a QA:ENG approach. The code is good to go, hence it's still in CR. |
QA Update: ❌@benbowler we have now renamed |
Thanks @wpdarren, I've updated this title and will move to CR once checks pass. |
@wpdarren The follow up PR is now merged. Remember to test on |
QA Update: ✅Verified:
|
@wpdarren @kuasha420 it's correct to update the field for consistency, but all module fields should be prefixed with the module name in the Site Health table. It's less obvious with the Ads module since it only has one field but when in doubt, it's good to look at other modules 👍 Also, the label and field key (used in debug output copied to clipboard) should match. I'll open a quick PR for this fix. |
No additional QA needed here as it's just a string change + the masking of the value. I've verified the change in Local while Code Reviewing. Moving back to approval. 🎉 |
Feature Description
As part of the new
Ads
module work being implemented, new Site Health checks are required to be added. These Site Health checks will be present in theSite Health > Info
section, and appear within theSite Kit by Google
health check group.Checks will include the following:
Ads Conversion ID
field valueDo not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Site Health > Info
section, and appear within theSite Kit by Google
health check group:Implementation Brief
includes/Modules/Ads/Tag_Matchers.php
includes/Modules/AdSense/Tag_Matchers.php
as a starting point.gtag('config','AW-12345')
. Ads conversion ID will always start withAW-
Google\Site_Kit\Modules\Ads
class:Module_With_Debug_Fields
andModule_With_Tag
interfacesModule_With_Tag_Trait
traitget_debug_fields
method, it should outputadsConversionID
setting. You can see the example of implementation in any other module, for exampleGoogle\Site_Kit\Modules\AdSense::get_debug_fields
get_tag_matchers
method, which should return the new Ads moduleTag_Matchers
classTest Coverage
tests/phpunit/integration/Modules/AdsTest.php
, to include test case forget_debug_fields
QA Brief
adsModule
feature flag and connect the Ads module in the SK settings.Tools > Site Health
, select theInfo
tab and open theSite Kit by Google
accordionTools > Site Health
, then clickPassed Tests
and expand theTag Placement
accordionPlace Google Analytics code
setting is enabledTools > Site Health
, then clickPassed Tests
and expand theTag Placement
accordionPlace Google Analytics code
setting for Analytics 4 module, should still confirm tha Tag placement for Ads module and show the same message "Tag detected and placed by Site Kit."Changelog entry
The text was updated successfully, but these errors were encountered: