Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create settings infrastructure for Consent Mode #8270

Closed
3 tasks
aaemnnosttv opened this issue Feb 19, 2024 · 1 comment
Closed
3 tasks

Create settings infrastructure for Consent Mode #8270

aaemnnosttv opened this issue Feb 19, 2024 · 1 comment
Labels
P0 High priority PHP Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Feb 19, 2024

Feature Description

Support for Consent Mode will introduce new settings on the settings screen. This issue is just about adding the main Setting infrastructure which is common for all settings.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Settings for Consent Mode should be added on the server side.
  • The shape of the settings should be be modelled as follows:
  'enabled' => boolean
  'regions' => array<ISO 3166-2 coded string>
  • The default value for enabled should be false.
  • The default value for regions should be the list of EEA country codes.

Implementation Brief

  • Follow the Consent_Mode_Settings class from the branch hack/como.
  • Include the Consent_Mode class from the above branch, but only include the parts which bootstrap the settings.
  • If the consentMode feature flag is enabled, register an instance of the Consent_Mode class in Plugin.

Test Coverage

  • Provide PHPUnit test coverage for the above changes.

QA Brief

  • No QA needed, test coverage can be verified during CR.

Changelog entry

  • Add settings model for Consent Mode.
@aaemnnosttv aaemnnosttv added P0 High priority Type: Enhancement Improvement of an existing feature PHP labels Feb 19, 2024
@aaemnnosttv
Copy link
Collaborator Author

IB ✅

@aaemnnosttv aaemnnosttv assigned techanvil and unassigned aaemnnosttv Feb 20, 2024
@techanvil techanvil added QA: Eng Requires specialized QA by an engineer and removed QA: Eng Requires specialized QA by an engineer labels Feb 21, 2024
@techanvil techanvil removed their assignment Feb 21, 2024
@techanvil techanvil assigned aaemnnosttv and unassigned techanvil Feb 21, 2024
@aaemnnosttv aaemnnosttv removed their assignment Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority PHP Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants