Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Consent Mode Setup CTA Banner from being shown if the user toggles Consent Mode via Settings. #8386

Closed
3 tasks
techanvil opened this issue Mar 12, 2024 · 3 comments
Labels
P2 Low priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Mar 12, 2024

Feature Description

At present, if the user doesn't engage with the Consent Mode Setup CTA Banner, and instead navigates directly to Settings and enables Consent Mode, then disables it again, when they return to the dashboard the Setup CTA Banner will be displayed.

We should probably ensure the banner is effectively dismissed if the user interacts with the Consent Mode toggle on the Settings screen.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Consent Mode Setup CTA banner, should not show again if the user has interacted with the Consent Mode toggle switch in the settings screen.

Implementation Brief

  • Update assets/js/components/consent-mode/ConsentModeSwitch.js:
    • Get the Consent Mode Setup CTA Banner dismissed state using the isPromptDismissed selector with the CONSENT_MODE_SETUP_CTA_WIDGET_SLUG slug.
    • In the saveSettings function, if the Consent Mode Setup CTA Banner has not been dismissed, dispatch the dismissPrompt actions with the CONSENT_MODE_SETUP_CTA_WIDGET_SLUG slug.

Test Coverage

  • None needed.

QA Brief

  • Set up a new site with Site Kit, including the Analytics module. Ensure that Consent Mode banner appears on the Site Kit dashboard, but don't interact with the banner.
  • Navigate to Site Kit settings.
  • Enable Consent Mode using the toggle switch from Site Kit settings.
  • Visit the Site Kit dashboard; the Consent Mode banner should no longer appear.

Changelog entry

  • Update the Consent Mode Setup CTA banner not to be shown if the user toggles the consent mode via settings.
@techanvil techanvil added the Type: Enhancement Improvement of an existing feature label Mar 12, 2024
@binnieshah binnieshah added the Next Up Issues to prioritize for definition label Jun 10, 2024
@benbowler benbowler assigned benbowler and unassigned benbowler Jun 10, 2024
@eugene-manuilov eugene-manuilov self-assigned this Jun 12, 2024
@eugene-manuilov
Copy link
Collaborator

AC ✔️

@eugene-manuilov eugene-manuilov removed their assignment Jun 12, 2024
@benbowler benbowler self-assigned this Jun 12, 2024
@binnieshah binnieshah added the Team S Issues for Squad 1 label Jun 14, 2024
@benbowler benbowler removed their assignment Jun 17, 2024
@eugene-manuilov eugene-manuilov self-assigned this Jun 17, 2024
@benbowler benbowler added the P2 Low priority label Jun 17, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️, but the estimate is too high, I'll change it to 3.

@eugene-manuilov eugene-manuilov removed their assignment Jun 17, 2024
@binnieshah binnieshah removed the Next Up Issues to prioritize for definition label Jun 25, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Jul 9, 2024
@mohitwp mohitwp self-assigned this Jul 11, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Jul 16, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified consent mode banner don't appear if the user toggles consent mode via settings.
Recording.1171.mp4

@mohitwp mohitwp removed their assignment Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Low priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

7 participants